-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add torch dist ckpt test to ci/cd #9154
Conversation
Signed-off-by: dimapihtar <dpihtar@gmail.com>
.github/workflows/cicd-main.yml
Outdated
@@ -4290,6 +4290,104 @@ jobs: | |||
- uses: "NVIDIA/NeMo/.github/actions/cancel-workflow@main" | |||
if: "failure()" | |||
|
|||
L2_Megatron_GPT_Pretraining_and_Resume_Training_Torch_Dist_TP2_PP2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding a new test can we update the existing tests to use torch dist?
Signed-off-by: dimapihtar <dpihtar@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: dimapihtar <dpihtar@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
What does this PR do ?
Adds torch distributed checkpoint test to ci/cd pipeline.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information